Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Selectable example #21

Merged
merged 6 commits into from
Dec 5, 2023

Conversation

jenny-s51
Copy link
Collaborator

@jenny-s51 jenny-s51 commented Nov 10, 2023

Removes references to deprecated v4 table.

Converted Selectable example to TSX/function components and refactored to use new PF5 Table

Towards #14 and #17

Copy link
Collaborator

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to resolve merge conflicts and add one missing type, other than that looks great!

Copy link
Contributor

@dlabaj dlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlabaj
Copy link
Contributor

dlabaj commented Dec 5, 2023

@jenny-s51 Looks like your test is failing.

@jenny-s51
Copy link
Collaborator Author

jenny-s51 commented Dec 5, 2023

@dlabaj thank you for taking a look - the fix for this is in this commit in the Filterable PR.

If we merge #25 in first, the build should pass when we merge this one in

@wise-king-sullyman wise-king-sullyman merged commit c84ce2b into patternfly:v6 Dec 5, 2023
4 checks passed
Copy link

github-actions bot commented Jun 3, 2024

🎉 This PR is included in version 1.0.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version 6.0.0-prerelease.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants